Added support for setting a group for SysV Shared Memory #354
Conversation
|
Looks like a good idea but we need more tests |
|
What tests would you like? |
|
It looks like |
|
So, what is needed are more tests to shm_detach() ? |
|
Any updates on this? What more is needed from me? I would like to add what is needed so we can proceed with the pull. |
|
@hackman Some tests covering the functionality you've added in the patch would be great. |
|
@hackman Any news? |
|
Sorry, I didn't had time to check what type of tests I have to create and also I'm not sure that I understand the test framework very well. It will take me some time to read it all. |
| @@ -58,6 +60,13 @@ | |||
| sysvshm_chunk_head *ptr; /* memory address of shared memory */ | |||
| } sysvshm_shm; | |||
|
|
|||
| typedef struct { | |||
There was a problem hiding this comment.
Why? It's already defined in grp.h
|
Comment on behalf of krakjoe at php.net: Since this PR does not have satisfactory test coverage, and since it has merge conflicts, and since it seems to have been abandoned by author, I'm closing the PR. If anyone is watching and thinks this needs to be merged, please open a clean PR, with good test coverage, and ensure tests are passing. |
I have added support for setting a valid group when attaching to the shared memory.
This allows you to create SHM and share it with users in a group which is not your default GID.
This is something that is missing in PHP since the addition of SysV SHM.