Skip to content

Add information about which INI file is which inside respective files #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
May 8, 2012

Conversation

oerdnj
Copy link
Contributor

@oerdnj oerdnj commented Apr 6, 2012

Hi,

I have added a simple oneliners into each INI file indicating which file is which. This may help in the situations when the php.ini file is already installed and the php user wants a quick information about the file used (of course he can diff the file against upstream version, but this is quicker and simpler).

@johannes
Copy link
Member

I don't think it's that useful in that form, as people will modify it, so "based on php.ini-foobar" makes more sense. And then it's changed with every release, so it might carry the version number, which adds trouble for the release process ... the good thing would have been old-style CVS/SVN $Id$ things. Maybe we should look into what git can provide there now.

@oerdnj
Copy link
Contributor Author

oerdnj commented Apr 12, 2012

That's true, and I am fine with based on php.ini-foobar.

Well, you don't have to use $Id$ tags, simple php.ini-{production,development}.in processed by autotools would give you the ability to put version number inside the ini file.

But I am not sure if this doesn't start to be bikeshedding :). You don't usually change php.ini-* between minor released, do you?

@johannes
Copy link
Member

There are certainly cases where that happens. for instance 5.3.9 added a new ini setting (max input vars), and no, autotools are no option as those won't work on Windows.

@oerdnj
Copy link
Contributor Author

oerdnj commented Apr 13, 2012

Ok, in that case I still think that even simple "based on php.ini-foobar" would be an improvement :).

@dsp
Copy link
Member

dsp commented May 2, 2012

Yes "based on" would be an improvement. We have $Id$ tags in git. See man gitattributes, but their are rather useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants