Skip to content

Fixbug: phpize --clean will delete include/*.h #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2013
Merged

Fixbug: phpize --clean will delete include/*.h #405

merged 1 commit into from
Aug 18, 2013

Conversation

matyhtf
Copy link
Contributor

@matyhtf matyhtf commented Aug 12, 2013

Command phpize --clean delete all head file in include directory. Fix the bug.

@jgmdev
Copy link

jgmdev commented Aug 12, 2013

mmm, while improving the wxwidgets php extension I noticed this behavior so I had to change header files location into the same directory but in plural form (includes) to prevent it's deletion, never thought of this as a bug, but an annoyance :) Would be nice to see this fix included, especially for big extensions that have a lot of header and source files. In this way headers can be kept on well known standard locations like the 'include' directory.

@php-pulls php-pulls merged commit 19312fa into php:master Aug 18, 2013
@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants