OnEnable INI MH for opcache causing strangeness #406
Conversation
|
is that possible to make a test script to show what this will cause? |
|
Well its only been reported by a pthreads user, I guess there might be a SAPI out there that does the same thing, the logic seems sound to me anyway and doesn't interfere with anything else ... |
|
I'm not sure this patch is correct - does it mean if the cache is enabled it can never be disabled at runtime? I don't think this is right. |
|
Apologies, logic makes sense now I think ... if it's enabled you can disable it, if it's disabled and you try to enable it, you still get an error ... |
|
Not quite, as this looks like if it's enabled and you try to enable it again, it will be disabled instead, which is not right. |
|
Right yeah ... awful ... |
|
This should have been simple ... I hate Mondays ... |
|
I can't get whitespace right, if it's merged can someone fix it, I dunno whats going on .. |
making sure that checks are only carried out if opcache is currently disabled makes sense generally and fixes a specific error in pthreads ... any chance this can be merged ?