Fix for php bug #64802 #410
Conversation
enabling SHA2 and RMD160 for openssl signature verification
| <?php | ||
| $cert = file_get_contents(__DIR__.'/bug64802.pem'); | ||
| $r = openssl_x509_parse($cert,$use_short_names=true); | ||
| var_dump( count($r['subject'])>1 ); |
There was a problem hiding this comment.
It is better to have actual list or count to be output. True/false tests are very hard to debug - if you get false, you have no idea what the actual count was. That's why we compare the output instead of making true/false tests.
There was a problem hiding this comment.
I had another version of the test that tested for actual keys in the response, like 'CN', 'O', 'L', 'ST' etc, but the return value of openssl_x509_parse states: "The structure of the returned data is (deliberately) not yet documented, as it is still subject to change.", so I submitted it as you saw it above.
But if you think its better, I can test previous for actual keys 'CN', 'O', etc, because the "subject to change" clause, probably has more to do with the X509v3 extensions, than the x509 subject.
|
Comment on behalf of stas at php.net: merged |
I included a test case as well.