use log2() / log10() within basic log function #461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +101,7 @@ | |||
| # elif SIZEOF_SHORT >= 2 | |||
| typedef unsigned short uint16_t; | |||
| # else | |||
| # error "No suitable 16bit integer type found" | |||
| // # error "No suitable 16bit integer type found" | |||
There was a problem hiding this comment.
The changes to this file seem unrelated. Are they accidental?
There was a problem hiding this comment.
Ow! This should not be committed - I revert it
|
@nikic reverted changes in main/stdint.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to reduce rounding errors
see #337
This PR implements the use of
log2/log10into PHP'slogfunction:log(x, 2)callslog2(x)log(x, 10)callslog10(x)log(x, y)callslog(x) / log(y)(as before)Should the PHP function
log10()be deprecated? Becauselog10(x)is the same aslog(x, 10).