Skip to content

fix bug #53432 (Assignment via string index access on an empty string converts to array) #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix bug #53432 (Assignment via string index access on an empty string converts to array) #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 0 additions & 214 deletions Zend/tests/indexing_001.phpt
View file
Open in desktop

This file was deleted.

60 changes: 60 additions & 0 deletions Zend/tests/indexing_bool_to_array.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
--TEST--
Indexing -- Convert boolean variable to array
--FILE--
<?php
$value = array(1);
require 'indexing_testing.inc';

run_test(true, $value, true);
run_test(false, $value, true);

run_test_ref(true, $value, true);
run_test_ref(false, $value, true);

run_test(true, $value, false);
run_test(false, $value, false);

run_test_ref(true, $value, false);
run_test_ref(false, $value, false);

?>
--EXPECTF--
Warning: Cannot use a scalar value as an array in %s on line %d
bool(true)
array(1) {
["foo"]=>
array(1) {
[0]=>
int(1)
}
}

Warning: Cannot use a scalar value as an array in %s on line %d
bool(true)
array(1) {
["foo"]=>
&array(1) {
[0]=>
int(1)
}
}

Warning: Cannot use a scalar value as an array in %s on line %d
bool(true)
array(1) {
[0]=>
array(1) {
[0]=>
int(1)
}
}

Warning: Cannot use a scalar value as an array in %s on line %d
bool(true)
array(1) {
[0]=>
&array(1) {
[0]=>
int(1)
}
}
26 changes: 26 additions & 0 deletions Zend/tests/indexing_float_to_array.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
--TEST--
Indexing -- Convert float variable to array
--FILE--
<?php
require 'indexing_testing.inc';
$value = array(1);

run_test(0.1, $value, true, false);
run_test(0.1, $value, true, true);

run_test(0.1, $value, false, false);
run_test(0.1, $value, false, true);

?>
--EXPECTF--
Warning: Cannot use a scalar value as an array in %s on line %d
float(0.1)

Warning: Cannot use a scalar value as an array in %s on line %d
float(0.1)

Warning: Cannot use a scalar value as an array in %s on line %d
float(0.1)

Warning: Cannot use a scalar value as an array in %s on line %d
float(0.1)
44 changes: 44 additions & 0 deletions Zend/tests/indexing_integer_to_array.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
--TEST--
Indexing -- Convert integer variable to array
--FILE--
<?php
require 'indexing_testing.inc';
$value = array(1);

run_test(1, $value, true);
run_test(0, $value, true);

run_test_ref(1, $value, true);
run_test_ref(0, $value, true);

run_test(1, $value, false);
run_test(0, $value, false);

run_test_ref(1, $value, false);
run_test_ref(0, $value, false);

?>
--EXPECTF--
Warning: Cannot use a scalar value as an array in %s on line %d
int(1)

Warning: Cannot use a scalar value as an array in %s on line %d
int(0)

Warning: Cannot use a scalar value as an array in %s on line %d
int(1)

Warning: Cannot use a scalar value as an array in %s on line %d
int(0)

Warning: Cannot use a scalar value as an array in %s on line %d
int(1)

Warning: Cannot use a scalar value as an array in %s on line %d
int(0)

Warning: Cannot use a scalar value as an array in %s on line %d
int(1)

Warning: Cannot use a scalar value as an array in %s on line %d
int(0)
45 changes: 45 additions & 0 deletions Zend/tests/indexing_null_to_array.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
--TEST--
Indexing -- Convert null to array
--FILE--
<?php
require 'indexing_testing.inc';
$value = array(1);

run_test(null, $value, true);

run_test_ref(null, $value, true);

run_test(null, $value, false);

run_test_ref(null, $value, false);

?>
--EXPECTF--
array(1) {
["foo"]=>
array(1) {
[0]=>
int(1)
}
}
array(1) {
["foo"]=>
&array(1) {
[0]=>
int(1)
}
}
array(1) {
[0]=>
array(1) {
[0]=>
int(1)
}
}
array(1) {
[0]=>
&array(1) {
[0]=>
int(1)
}
}
Loading