Skip to content

Better wildcard matching for CN #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2013
Merged

Better wildcard matching for CN #465

merged 6 commits into from
Oct 8, 2013

Conversation

datibbaw
Copy link
Contributor

This is a fix for https://bugs.php.net/bug.php?id=65729

It also allows for better wildcard matching, such as foo*.bar.com and *baz.foo.com, as per rfc 2818.

@rdlowrey
Copy link
Contributor

+1

@m6w6
Copy link
Contributor

m6w6 commented Oct 3, 2013

Commit?! :)

@datibbaw
Copy link
Contributor Author

datibbaw commented Oct 3, 2013

@m6w6 I lack the magic wand ;-)

@m6w6
Copy link
Contributor

m6w6 commented Oct 4, 2013

Okay then... I just had a closer look: this one test that is supposed to fail doesn't seem to be enough to proof the functionality of such a sensitive feature.

@datibbaw
Copy link
Contributor Author

datibbaw commented Oct 4, 2013

Hi,

On 4 Oct, 2013, at 3:26 PM, Michael Wallner notifications@github.com wrote:

Okay then... I just had a closer look: this one test that is supposed to fail doesn't seem to be enough to proof the functionality of such a sensitive feature.

I agree, but should I generate a slew of certificates or how should I add test cases for this? :)

—
Reply to this email directly or view it on GitHub.

@rdlowrey
Copy link
Contributor

rdlowrey commented Oct 4, 2013

@datibbaw There are several other cert files in ext/openssl/tests that exist for other tests -- you could use those in lieu of adding more.

@datibbaw
Copy link
Contributor Author

datibbaw commented Oct 7, 2013

@rdlowrey Yes, there are some, but none have a wildcard; in fact, I don't even see test cases for the current behaviour of "CN_match" in terms of wildcard matching =P

@php-pulls php-pulls merged commit 6106896 into php:master Oct 8, 2013
@datibbaw datibbaw deleted the bug65729 branch October 11, 2013 01:52
@ravage84 ravage84 mentioned this pull request Oct 15, 2013
Closed
@DavidOliver DavidOliver mentioned this pull request Sep 1, 2015
Closed
@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
devnexen added a commit to devnexen/php-src that referenced this pull request Jan 14, 2025
@devnexen
Fix phpGH-17463: SplTempFileObject::ftruncate() segfault on negative …
1a270ea 
…length.

close phpGH-465
devnexen added a commit that referenced this pull request Jan 14, 2025
@devnexen
Fix GH-17463: SplTempFileObject::ftruncate() segfault on negative len…
e4473ab 
…gth.

close GH-465
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
@devnexen @charmitro
Fix phpGH-17463: SplTempFileObject::ftruncate() segfault on negative …
0c88c1e 
…length.

close phpGH-465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datibbaw @rdlowrey @m6w6 @php-pulls