-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Allow ini files to have a [SAPI=] section in exactly the same manner as ... #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…as [PATH=] and [HOST=]. All SAPIs are capable of having their own sections in any ini file.
@rquadling, Seems this is identical for #467 and #468 , so they can be closed. If the changes are relevant for the PHP 5.4 branch, they will be merged back to 5.5 and master. |
I wasn't sure if I needed to do a patch for each branch. Thank you for
|
Hrm... I think I closed the bug report about that topic a few days ago with "Won't fix" (because we already have SAPI dependent INI files). |
But you can't use SAPI specific ini files in the additional ini path. On the servers I'm interacting with that is the only place for ini files. Each extension has its own ini file in the additional ini directory, so Whilst I am very familiar with SAPI specific files (big fan when I was a The patch I've supplied does just that. 99% of the ini file is the same for all SAPIs. That 1% difference is If I was allowed to build my own code on their servers, then this wouldn't I do fully appreciate that this is yet another option to maintain, but it Kind regards, Richard Quadling. On 4 October 2013 08:43, Michael Wallner notifications@github.com wrote:
Richard Quadling |
My bad ... :-/ I closed https://bugs.php.net/bug.php?id=53358 instead of https://bugs.php.net/bug.php?id=65681 :) |
Is there anything else I need to do to get this merged into core? |
Has it been discussed on internals? |
Comment on behalf of krakjoe at php.net: Since this PR targets an unsupported version of PHP, and since it requires an RFC and discussion to move forward, I'm closing this PR. Please take this action as encouragement to create a clean PR, if possible (not sure if possible) with tests, targeting the correct branch. In addition, please create an RFC and start an internals discussion. |
...[PATH=] and [HOST=]. All SAPIs are capable of having their own sections in any ini file.