-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add Symfony back in the community test suite #4666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure where I should read the output for the related jobs? Could anyone point me at past ones? |
Symfony is still enabled on 7.4, the reason why I dropped it on master is that phpunit doesn't install due to platform requirements (it is not compatible with PHP 8 and there is no way to pass You can edit https://github.com/php/php-src/blob/master/azure-pipelines.yml and drop everything but the community job to check whether it works. It's not run on pull request builds. |
be343c7
to
061550d
Compare
got it, the attached patch should work around the issue, don't you think? |
What is the relation between flex and the memory_limit? We can also change the memory_limit. It is possible to run |
When there are too many legacy tags, the matrix explodes, see symfony/flex#378 which introduced the workaround exactly for this reason. |
e33ce5a
to
3eace42
Compare
I pushed symfony/symfony@62020ab on the bridge to give it the flexibility we need here. Be careful if you want to do further tweaks, I push-forced on my branch. |
3eace42
to
6f0bde4
Compare
6f0bde4
to
e9bdd81
Compare
Yay, looks like it works. Also one ubsan warning (also on 7.4 but got lost in the log): Should probably configure it to abort instead of only printing a message. |
Cool! What's the next step? There are failures, errors, deprecation notices (a bunch of them, dunno why as I don't have them on 7.3) |
The next step should just be to merge it, we don’t really care about deprecations, notices etc on a userland level but the results of the ub tooling on the test suites :) |
Partially backported via #4672 and then merged up. The symfony run was successful in https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=2567. |
It was disabled in #1054, but this should make it OK.
Feel free to ping me when you have any issue with this test suite, I'd be happy to help maintain it.