Fix segfault when built with OpenSSL >= 1.0.1 #481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I provoke the crash? A test the fails now and works woth the patch would be awesome! |
|
Oh well, I suppose the other PRs depend on this one and their tests would crash? |
|
That's correct. I was unsure of how to add a test because it really just boils down to the extension using code that is no longer valid with newer versions of OpenSSL. Just build against OpenSSL v1.0.1 and you'll get failed tests in the openssl suite without this patch. |
|
You don't actually need to use any of the recent PRs to see this behavior. Simply build the existing master branch against OpenSSL 1.0.1 and you'll get failed tests (which are fixed by this PR). |
php-pulls
pushed a commit
that referenced
this pull request
Oct 9, 2013
|
Erm... did a patch instead of a cherry, so your have to close this PR yourself :) Sorry |
|
No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes segfaults encountered when using
ext/opensslbuilt against OpenSSL >= 1.0.1. This newer version of OpenSSL is required for TLSv1.1 and TLSv1.2 support.Note that this patch has no BC implications and should be safe to merge with 5.4 and 5.5 branches.