Client-Initiated Renegotiation DoS Vulnerability #486
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| --TEST-- | ||
| Encrypted server rate-limits client-initiated TLS renegotiation | ||
| --SKIPIF-- | ||
| <?php | ||
| if (!extension_loaded("openssl")) die("skip"); | ||
| if (!function_exists('pcntl_fork')) die("skip no fork"); | ||
| exec('openssl help', $out, $code); | ||
| if ($code > 0) die("skip couldn't locate openssl binary"); | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| /** | ||
| * This test uses the openssl binary directly to initiate renegotiation. At this time it's not | ||
| * possible renegotiate the TLS handshake in PHP userland, so using the openssl s_client binary | ||
| * command is the only feasible way to test renegotiation limiting functionality. It's not an ideal | ||
| * solution, but it's really the only way to get test coverage on the rate-limiting functionality | ||
| * given current limitations. | ||
| */ | ||
|
|
||
| $bindTo = 'tcp://127.0.0.1:12345'; | ||
| $flags = STREAM_SERVER_BIND | STREAM_SERVER_LISTEN; | ||
| $server = stream_socket_server($bindTo, $errNo, $errStr, $flags, stream_context_create(['ssl' => [ | ||
| 'local_cert' => dirname(__FILE__) . '/bug54992.pem', | ||
| 'max_handshake_rate' => 1 | ||
| ]])); | ||
|
|
||
| $pid = pcntl_fork(); | ||
| if ($pid == -1) { | ||
| die('could not fork'); | ||
| } elseif ($pid) { | ||
|
|
||
| $cmd = 'openssl s_client -connect localhost:12345'; | ||
| $descriptorspec = array( | ||
| 0 => array("pipe", "r"), | ||
| 1 => array("pipe", "w"), | ||
| 2 => array("pipe", "w"), | ||
| ); | ||
| $process = proc_open($cmd, $descriptorspec, $pipes); | ||
|
|
||
| list($stdin, $stdout, $stderr) = $pipes; | ||
|
|
||
| // Trigger renegotiation twice | ||
| // Server settings only allow one per second (should result in disconnection) | ||
| fwrite($stdin, "R\nR\n"); | ||
|
|
||
| $lines = []; | ||
| while(!feof($stderr)) { | ||
| fgets($stderr); | ||
| } | ||
|
|
||
| fclose($stdin); | ||
| fclose($stdout); | ||
| fclose($stderr); | ||
| proc_close($process); | ||
| pcntl_wait($status); | ||
|
|
||
| } else { | ||
|
|
||
| $clients = []; | ||
| while (1) { | ||
| $r = array_merge([$server], $clients); | ||
| $w = $e = []; | ||
| stream_select($r, $w, $e, $timeout=1); | ||
|
|
||
| foreach ($r as $sock) { | ||
| if ($sock === $server && ($client = @stream_socket_accept($server, $timeout = 1))) { | ||
| stream_socket_enable_crypto($client, TRUE, STREAM_CRYPTO_METHOD_TLS_SERVER); | ||
| $clientId = (int) $client; | ||
| $clients[$clientId] = $client; | ||
| } else { | ||
| $clientId = (int) $client; | ||
| $buffer = @fread($sock, 1024); | ||
|
|
||
| if (strlen($buffer)) { | ||
| continue; | ||
| } elseif (feof($sock)) { | ||
| $meta = !empty(stream_get_meta_data($sock)['wrapper_data']['handshake_limit_exceeded']); | ||
| var_dump($meta); | ||
| fclose($sock); | ||
| unset($clients[$clientId]); | ||
| break 2; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| --EXPECTF-- | ||
| bool(true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both
streamandsslock, never ever could be NULL?