Imap send #52
Closed
Imap send #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int rpath_length = strlen(rpath); | ||
| int sendmail_length = strlen(sendmail_path); | ||
| char *force_extra_parameters = INI_STR("mail.force_extra_parameters"); | ||
| char *extra_cmd = NULL; |
There was a problem hiding this comment.
Declarations have to go first in the block to be compliant with ANSI C. Either move the declarations up or put this in a block.
|
Looks like this patch is abandoned - no response to comments for a year. I am closing this pull, if somebody is interested in taking it to completion please reopen it. |
|
Comment on behalf of stas at php.net: closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup of my imap_mail patch,
it attempts to fix the following bug
https://bugs.php.net/bug.php?id=30688