Improve the default value format in incompatible signature error messages #5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Apr 9, 2020
87f1cc5 to
18dbd2d
Compare
carusogabriel
approved these changes
Apr 10, 2020
|
@carusogabriel I think PHP 8 will have a lot of these, so it's a great feeling :) My current favourite one is the unclosed character syntax error stuff ^^ |
nikic
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up for #5353, the changes are related to parameter default values of user-land functions:
NULLtonullArrayis now shown as<array>I'm not 100% sure about the second change, but I like its consistency with
<expression>and<default>. That said, I'm interested in other solutions as well to makeArrayconsistent with the other placeholders.