Fixed bug #60106 test bug by increasing log_errors_max_len #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for spoting this, you patch is okey, but actually, the su_path will not be that much long, so I just simply reduce the path length. |
|
Comment on behalf of laruence at php.net: close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This bugfix(#60106)'s test failed because the default log_erros's buffer length is log_errors_max_len=1024.
but this test output 4086+13 bytes. then some 'a's are missing. so the test failed.
in this bug https://bugs.php.net/bug.php?id=61518 mattficken@php.net mention it too.
Thanks.