Fix preloading of constants containing enums #8373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
commented
Apr 14, 2022
| @@ -762,13 +768,6 @@ ZEND_API zend_result ZEND_FASTCALL zend_ast_evaluate(zval *result, zend_ast *ast | |||
| : NULL; | |||
|
|
|||
| zend_class_entry *ce = zend_lookup_class(class_name); | |||
| if (!ce) { | |||
There was a problem hiding this comment.
I'm not 100% sure if this can be removed
There was a problem hiding this comment.
You could always add ZEND_ASSERT(ce); which would crash if such a case exists
nikic
approved these changes
Apr 14, 2022
nikic
reviewed
Apr 14, 2022
|
Merged as 4397811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-8133