Skip to content

mb_detect_encoding recognizes all letters in Czech alphabet #8624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexdowad
Copy link
Contributor

As discussed in #8439.

@cmb69 @mvorisek @ramsey

@alexdowad
Copy link
Contributor Author

Waiting to see CI results before merging.

@alexdowad alexdowad closed this May 25, 2022
@alexdowad alexdowad deleted the czech branch May 25, 2022 05:54
@ramsey
Copy link
Member

ramsey commented May 25, 2022

@alexdowad When merging, try to follow the guidelines in https://wiki.php.net/vcs/gitworkflow#merge_a_pull_request

Specifically:

Adjust commit message to add "Closes GH-1234."

There's no way to tell that 6a4b6d2 is linked to this PR.

Thanks! 😄

@alexdowad
Copy link
Contributor Author

@alexdowad When merging, try to follow the guidelines in https://wiki.php.net/vcs/gitworkflow#merge_a_pull_request

Specifically:

Adjust commit message to add "Closes GH-1234."

There's no way to tell that 6a4b6d2 is linked to this PR.

Thanks! smile

Will do, thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants