Skip to content

Fix GH-8943: Reflection::getModifiersNames() with readonly modifier #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-8943: Reflection::getModifiersNames() with readonly modifier #8944

wants to merge 1 commit into from

Conversation

adoy
Copy link
Member

@adoy adoy commented Jul 7, 2022 •
edited
Loading

This fixes only fixes PHP-8.1

I plan to add ZEND_ACC_READONLY_CLASS when merging into master to also support ReflectionClass::IS_READONLY

@adoy
Copy link
Member Author

adoy commented Jul 7, 2022

Merged as c650e67

@adoy adoy closed this Jul 7, 2022
@adoy adoy mentioned this pull request Jul 7, 2022
Closed
@adoy adoy deleted the bugfix/gh-8943 branch July 7, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adoy @iluuu1994 @cmb69