Fixed bug #61964 (finfo_open with directory cause invalid free) #91
Conversation
|
..... Double free is no doubt a bug, the reason I care is lib magic is not ready for that in php, as I said there even was code fprintf(stderr... So I think it should be whole examed by somebody who really know it. But not do a little fix one by one, Thanks |
|
Hm,.. from the commit log , seems Felipe & Pierre knows about it, we could ask them to improve it. |
|
Thanks for looking into this @reeze :) |
|
for the record, as felipe said, this patch cause segfault. need to be re-examed. |
|
Comment on behalf of stas at php.net: Looks like the patch is not right (see the bug, it segfaults) so please fix and resubmit the pull, I'll close this one for now. |
|
Hi, stas: https://github.com/php/php-src/pull/91/files#L1R31. Thanks for reply! |
|
BTW: The reason there is only on commit is that I want to make the commit clean I update the PR by force-update. |
Hi,
we have been discuss this issue in irc, @laruence got some concern,
then I sent a mail to the file lib author: Christos Zoulas christos@zoulas.com.
he replied:
both 5.3&5.4 didn't use asprintf(), we use our memory management functions.
after got his reply I think I can send this PR to ask you guys comment.
Thanks.