[PHP7] Removed ZEND_ACC_FINAL_CLASS which is unnecessary. #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -655,7 +655,7 @@ PHP_MINIT_FUNCTION(mysqli) | |||
|
|
|||
| REGISTER_MYSQLI_CLASS_ENTRY("mysqli_warning", mysqli_warning_class_entry, mysqli_warning_methods); | |||
| ce = mysqli_warning_class_entry; | |||
| ce->ce_flags |= ZEND_ACC_FINAL_CLASS | ZEND_ACC_PROTECTED; | |||
There was a problem hiding this comment.
This configuration was somehow broken... we do not support protected classes (yet).
a710417 to
b3a4c6a
Compare
This was referenced Dec 1, 2014
Closed
|
The documentation doesn't mention that |
|
@datibbaw In reality, it is acually PDORow that is final, not PDOStatement... sorry for the misconception. |
b3a4c6a to
6e8abfa
Compare
added 2 commits
December 6, 2014 04:50
…me currently defined classes as final which were just not being considered as such before.
6e8abfa to
db522c4
Compare
|
Merged |
php-pulls
pushed a commit
that referenced
this pull request
Dec 13, 2014
* origin/master: (37 commits) NEWS NEWS Fix bug #68601 buffer read overflow in gd_gif_in.c Fixed compilation warnings Removed unnecessary checks pcntl_signal_dispatch: Speed up by preventing system calls when unnecessary Merged PR #911. Removed ZEND_ACC_FINAL_CLASS which is unnecessary. This also fixed some currently defined classes as final which were just not being considered as such before. Updated NEWS Updated NEWS Updated NEWS Fix bug #68532: convert.base64-encode omits padding bytes Updated NEWS Updated NEWS Updated NEWS Fixed Bug #65576 (Constructor from trait conflicts with inherited constructor) Updated NEWS Updated NEWS Fix MySQLi tests Fixed gd test ...
dstogov
added a commit
to zendtech/php-src
that referenced
this pull request
Feb 27, 2015
* master: Fixed compilation warnings Removed unnecessary checks pcntl_signal_dispatch: Speed up by preventing system calls when unnecessary Merged PR php#911. Removed ZEND_ACC_FINAL_CLASS which is unnecessary. This also fixed some currently defined classes as final which were just not being considered as such before. Updated NEWS Updated NEWS Updated NEWS Fix bug #68532: convert.base64-encode omits padding bytes Updated NEWS Updated NEWS Updated NEWS Fixed Bug #65576 (Constructor from trait conflicts with inherited constructor) Updated NEWS Updated NEWS updated NEWS PowerPC64 support for add and sub with overflow check PowerPC64 support for operators with overflow check Fixed bug #68583 Crash in timeout thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixed some currently defined classes as final which were just not being considered as such before, such as COM, PDO Statement, DOM XML and MySQLi.
Motivation is initially optimize compilation flags usage for further expansion of class modifiers.