Fix GH-8517: FPM child pointer can be possibly uninitialized #9444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be noted that the initial implementation might introduce extra load on master process due to the child searching which is not exactly optimal. If the issue is confirmed and the extra load is visible, some extra optimization can be added. However if there's not much extra load visible, we could leave the optimization to more stable version as they are more risky. |
devnexen
approved these changes
Aug 29, 2022
|
Merged via c9c1934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that there might be a moment when the child log event is executed after freeing child. That could possibly happen if child output is triggered at the same time like terminating the child. Then the output event could be potentially processed after the terminating event which would cause this kind of issue.
The issue might got more visible after introducing the
log_streamon child because it is more likely that this cannot be dereferenced after free. However it is very hard to reproduce this issue so this is still a guess based on the logs and code.