Added recursivetreeiterator::setPostfix() method #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| smart_str_appendl(&str, object->postfix[0].c, object->postfix[0].len); | ||
| smart_str_0(&str); | ||
|
|
||
| RETVAL_STRINGL(str.c, str.len, 0); |
There was a problem hiding this comment.
Why can't you just return a copy of object->postfix[0].c?
There was a problem hiding this comment.
In this case, you could. The code is pretty much taken from the get_prefix() to make it easier to implement the same structure as the prefix in a later stage.
|
@jaytaph could you copy object->postfix[0].c. Otherwise the patch looks good. |
|
@jaytaph ping |
|
@jaytaph ping again |
|
sorry.. extremely busy right now.. will change the patch as soon as I can find some spare time.. |
|
Comment on behalf of stas at php.net: merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a recursivetreeiterator::setPostfix method since it was not present. The getPostFix() method returns the string as set through this method, and the current() method will add the postfix to the actual current value (as stated in the documentation).