Faster sorting algo #999
Merged
Faster sorting algo #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much improvement do the custom swap functions make? Are they a critical part of this improvement? |
|
@nikic it depends, for renum zend_hash_sort, it can save 2 words per exchange.. anyway, it's not the critical part, but for consistent, as you can see, zend_sort_swap require a third parameter siz. but custom swap function doesn't need(swap_func_t). thus, I'd like keep the swap_func_t to be consistent. thanks |
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Jan 17, 2015
ArrayUtilityTests expect that order of elements with the same value will not change. PHP doesn't guarantee that, so it doesn't make sense to test this behaviour. This test fails under HHVM which has different sorting implementation than PHP 5. Actually PHP 7 is going into the same direction, so sooner or later this test will fail also under PHP. See php/php-src#999 and facebook/hhvm#4649 Resolves: #64322 Releases: master Change-Id: Ie48e57456eee20ff9b1a0efc0ac38413f16c5de1 Reviewed-on: http://review.typo3.org/36055 Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de> Reviewed-by: Markus Klein <klein.t3@reelworx.at> Tested-by: Markus Klein <klein.t3@reelworx.at>
| +----------------------------------------------------------------------+ | ||
| */ | ||
|
|
||
| /* $Id$ */ |
There was a problem hiding this comment.
This line isn't really needed, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which could brings us >30% performance improvement in sort series functions.
lots of tests fails due to non-stable sorting vs stable sorting difference(we are using insert sorting algo while elements is le 16)