Add search method #371
Merged
Add search method #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for the pull request. Can't say I've needed this request method, but seems fine. Will wait until the build finishes. |
|
Hi @zachborboa I like php-curl-class and I use it for many projects. Right now I am working on not trivial CURL RESTFul service where SEARCH method used instead of GET with params. SEARCH method is exactly what we need here (send search params in JSON format). I see that build finished with strange error while tests shows OK. Is here anything that I can do about it? PS thank you for php-curl-class! I like it. |
zachborboa
added a commit
that referenced
this pull request
Aug 12, 2016
|
Hi @Gormartsen Glad you like it! I've merged your changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a common used method for HTTP.
Some documentation could be found here:
http://www.w3.org/Protocols/HTTP/Methods.html
http://www.iana.org/assignments/http-methods/http-methods.xhtml
https://tools.ietf.org/html/rfc5323