Skip to content

Drop support for PHP 7.1 #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ jobs:
strategy:
matrix:
php-version:
- '7.1'
- '7.2'
- '7.3'
- '7.4'
Expand Down Expand Up @@ -50,4 +49,4 @@ jobs:

- name: Static analysis
run: 'vendor/bin/psalm --config="tests/psalm.xml"'
if: ${{ !matrix.future-release && matrix.php-version >= 7.1 }}
if: ${{ !matrix.future-release }}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Installation instructions to use the `composer` command can be found on https://

### Requirements

PHP Curl Class works with PHP 8.3, 8.2, 8.1, 8.0, 7.4, 7.3, 7.2, and 7.1.
PHP Curl Class works with PHP 8.3, 8.2, 8.1, 8.0, 7.4, 7.3, and 7.2.

### Quick Start and Examples

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
],
"require": {
"php": ">=7.1",
"php": ">=7.2",
"ext-curl": "*"
},
"require-dev": {
Expand Down
42 changes: 18 additions & 24 deletions tests/check_coding_standards.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,35 +93,29 @@ if [[ ! -z "${elses}" ]]; then
fi

# Run PHP_CodeSniffer.
if [[ "${CI_PHP_VERSION}" == "7.1" ]]; then :
# Determine which phpcs to use.
if [[ -f "vendor/bin/phpcs" ]]; then
phpcs_to_use="vendor/bin/phpcs"
else
phpcs_to_use="phpcs"
fi

# Determine which phpcs to use.
if [[ -f "vendor/bin/phpcs" ]]; then
phpcs_to_use="vendor/bin/phpcs"
else
phpcs_to_use="phpcs"
fi

# Detect coding standard violations.
"${phpcs_to_use}" --version
"${phpcs_to_use}" \
--extensions="php" \
--ignore="*/vendor/*" \
--standard="tests/ruleset.xml" \
-p \
-s \
.
if [[ "${?}" -ne 0 ]]; then
echo "Error: found PHP_CodeSniffer coding standard violation(s)"
errors+=("found PHP_CodeSniffer coding standard violation(s)")
fi

# Detect coding standard violations.
"${phpcs_to_use}" --version
"${phpcs_to_use}" \
--extensions="php" \
--ignore="*/vendor/*" \
--standard="tests/ruleset.xml" \
-p \
-s \
.
if [[ "${?}" -ne 0 ]]; then
echo "Error: found PHP_CodeSniffer coding standard violation(s)"
errors+=("found PHP_CodeSniffer coding standard violation(s)")
fi

# Run PHP-CS-Fixer.
if [[ "${CI_PHP_VERSION}" == "7.1" ]]; then :
elif [[ "${CI_PHP_VERSION}" == "7.2" ]]; then :
if [[ "${CI_PHP_VERSION}" == "7.2" ]]; then :
elif [[ "${CI_PHP_VERSION}" == "7.3" ]]; then :
else
vendor/bin/php-cs-fixer --version
Expand Down
3 changes: 0 additions & 3 deletions tests/dockerfiles/php71/1_build.sh

This file was deleted.

15 changes: 0 additions & 15 deletions tests/dockerfiles/php71/2_start.sh

This file was deleted.

17 changes: 0 additions & 17 deletions tests/dockerfiles/php71/3_test.sh

This file was deleted.

3 changes: 0 additions & 3 deletions tests/dockerfiles/php71/4_stop.sh

This file was deleted.

19 changes: 0 additions & 19 deletions tests/dockerfiles/php71/Dockerfile

This file was deleted.

3 changes: 0 additions & 3 deletions tests/dockerfiles/php71/attach.sh

This file was deleted.

23 changes: 0 additions & 23 deletions tests/dockerfiles/php71/run.sh

This file was deleted.

14 changes: 0 additions & 14 deletions tests/dockerfiles/php71/run_interactive.sh

This file was deleted.