Skip to content

ExceptionsCollector easy to extend #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ExceptionsCollector easy to extend #749

wants to merge 2 commits into from

Conversation

cesarreyes3
Copy link
Contributor

In case #748 doesn't get merged, i could extend the class with that code and just return

public function collect() {
    return array(
        'count' => count($this->exceptions),
        'exceptions' => $this->exceptions
    );
}

Also for anyone who wants to extend the same class, just with another name

@barryvdh
Copy link
Collaborator

barryvdh commented Apr 8, 2025

Is this still required?

@cesarreyes3
Copy link
Contributor Author

After the other PR is merged, it is not required by me, but it does not affect anything if someone wants to use it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cesarreyes3 @barryvdh