-
Notifications
You must be signed in to change notification settings - Fork 411
Support doctrine 3.x #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Support doctrine 3.x #770
Conversation
7d8934c
to
4ebd1f6
Compare
1cc1e98
to
179644f
Compare
Would it make more sense to create php-debugbar/doctrine-bridge or something? |
It's a bit difficult to pin dependencies and things like that. And making changes or upgrading in the future with breaking changes, make it also difficult. |
Maybe, but since there was already support for 2x I thought about adding it here.
Is it because of the integration test? Yes, it's difficult. |
well yeah it's mostly difficult because we don't actually add the depencies so we cannot bump anything. |
In my opinion, the only thing that saves this type of thing is that it is not a production package, you can adapt it to your local environment in your own way. |
merge?.. New way is not worse performance-wise right? |
That shouldn't be the case, but try it and tell us, I don't use Doctrine, I'm just trying to help |
I think I'm gonna make a seperate repo. Just thinking about how to do it cleanly. Shall I make the base package and let @erikn69 PR his code (copy paste) it? |
https://www.doctrine-project.org/projects/doctrine-orm/en/3.3/reference/configuration.html
The code was moved from
\DebugBar\Bridge\DoctrineCollector
to\DebugBar\Bridge\Doctrine\DoctrineCollector
and the middleware was added, it keeps 2.x support on\DebugBar\Bridge\DoctrineCollector
the middleware wraps doctrine connection, is there a better way to achieve this?
UPDATE1: it seems that doctrine 3.x does not support php 8.0
UPDATE2:
durationBackground
added, events liketransaction
are now better differentiated, events are avoided from being counted asstatements