Fixing segfault in cluster_update_slot #2552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the slot's->slaves was null, it was dereferencing null, causing segfault. This happens in weird scenario when some of the nodes in cluster are down or having changed IP addresses without knowing about it.
|
Thanks! I'm actually tagging 6.1.0RC2 right now. This is a small change, so we might be able to get it into 6.1.0 GA; if not, we can do 6.1.1 soon after 6.1.0 |
|
No problem. If you wanted to spend time on it, there might be a better solution, as I only added throwing an exception right before it dereferences a null ->slaves in the case where I saw my php-fpm segfaulting. There may be other places where this is happening, as I haven't checked yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the slot's->slaves was null, it was dereferencing null, causing segfault.
This happens in weird scenario when some of the nodes in cluster are down or having changed IP addresses without knowing about it.