Skip to content

Fix stub of RedisCluster::zremrangebyrank #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix stub of RedisCluster::zremrangebyrank #2623

wants to merge 1 commit into from

Conversation

adsr
Copy link

@adsr adsr commented Feb 11, 2025

The stub is currently defined as

RedisCluster|int|false zremrangebyrank(string $key, string $min, string $max)

however the underlying function expects ints

phpredis/redis_cluster.c

Lines 1392 to 1397 in abb0f6c

/* {{{ proto long RedisCluster::zremrangebyrank(string k, long s, long e) */
PHP_METHOD(RedisCluster, zremrangebyrank) {
CLUSTER_PROCESS_KW_CMD("ZREMRANGEBYRANK", redis_key_long_long_cmd,
cluster_long_resp, 0);
}
/* }}} */

I re-ran gen_stub.php which updated some other stuff.

doctum fatals with my local version of PHP so I didn't update docs.

@michael-grunder michael-grunder added this to the 7.0 milestone Feb 11, 2025
@michael-grunder
Copy link
Member

Good catch.

To be safe we probably have to dever merging this until we are preparing v7.0 as it is technicall BC. I already accidentally broke BC in 6.1.0 and don't want to do that again. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adsr @michael-grunder