Skip to content

Refactor getWithMeta logic #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Refactor getWithMeta logic #2643

merged 3 commits into from
Mar 31, 2025

Conversation

michael-grunder
Copy link
Member

Small refactor to the getWithMeta methods to use their own custom reply handlers instead of toggling flags before and after the call.

Copy link
Member

@yatsukhnenko yatsukhnenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small comments

@michael-grunder michael-grunder merged commit 0445e68 into develop Mar 31, 2025
143 of 146 checks passed
@michael-grunder michael-grunder deleted the refactor/getwithmeta branch March 31, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants