Skip to content

Conversation

wyattoday
Copy link
Contributor

When compiling the develop branch it fails with PHP 8.5.0 alpha 3 and newer due to this commit: php/php-src#19233

/loc/php-8.5.0alpha3/ext/phpredis/common.h:14:10: fatal error: ext/standard/php_smart_string.h: No such file or directory
   14 | #include <ext/standard/php_smart_string.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This PR fixes that issue (by including the non-deprecated header) while also being backward compatible with no longer supported versions of PHP (7.2 and older).

Copy link
Collaborator

@remicollet remicollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (same as PR #2677)

@michael-grunder michael-grunder merged commit 9cae781 into phpredis:develop Jul 30, 2025
71 of 72 checks passed
crazywhalecc added a commit to crazywhalecc/static-php-cli that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants