Add support for negatable input options #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since symfony/console 5.3, input options can be marked as negatable. The appropriate return type when calling `$input->getOption()` can be either a boolean or null. With this change, support for return types of such negatable input options is added.
|
Perfect, thank you! |
|
Hi @eliashaeussler, @ondrejmirtes, after merging/releasing 1.2.11 we experience problems with the older Symfony projects. I have no idea how to debug this further at this point. Can I contribute to this bug report? Would you rather have a separate issue? Please let me know. composer info symfony/symfony | grep 'versions'composer info phpstan/phpstan-symfony | grep 'versions'php -vSymfony command <?php
namespace CoreDomainBundle\Command;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
final class PhpStanErrorCommand extends Command
{
protected function configure(): void
{
$this->setName('phpstan:error');
$this->addOption('test-option');
}
protected function execute(
InputInterface $input,
OutputInterface $output
): ?int {
$input->getOption('test-option');
return 0;
}
}PHPStan config parameters:
tmpDir: var/ci/phpstan/
level: 8
paths:
- src/CoreDomainBundle/Command/PhpStanErrorCommand.php
symfony:
consoleApplicationLoader: .phpstan/console-application.phpphp ./vendor/bin/phpstan analyse --no-progress --memory-limit=-1 -v |
|
Hi @cafferata, thanks for your report and sorry, that I've missed that aspect. I pushed a fix, see #305. |
ondrejmirtes
pushed a commit
that referenced
this pull request
Aug 26, 2022
|
@cafferata @eliashaeussler Thanks. We no longer test older Symfony versions, it should be your priority to upgrade to a supported version (5.3+). But I accepted a quickfix for this problem. |
Hi @eliashaeussler, thanks for the quick fix! 👏
This project is in the middle of a upgrade to a supported version. But in the meantime all the Composer packages are updated weekly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symfony/console 5.3 (symfony/symfony#39642), input options can be marked as "negatable". The appropriate return type when calling
$input->getOption()can be either a boolean ornull. With this change, support for return types of such negatable input options is added.