Enable initial Travis CI workflow #183
Conversation
Data cleanse - correct owner names and strip errant spaces (pidcodes#176)
Resync with master
Escape the colons in the title (pidcodes#180)
Resync with master
| </a> | ||
| <p class="post-summary"> | ||
| <div class="post-summary"> |
There was a problem hiding this comment.
Hopefully this doesn't break the look, but htmlproofer complains about the closing /p.
There was a problem hiding this comment.
Let me know if it does @Arachnid and I'll do something else instead.
There was a problem hiding this comment.
Looks fine still to me.
|
Oh wow, amazing job - thank you! RE external links, it'd be good to catch people submitting invalid URLs in their submissions, but I definitely don't want to block one person's PR because another's has gone 404. In the absence of some way to do that, I'd err on the side of not validating them. |
| @@ -7,6 +7,6 @@ permalink: /pids/ | |||
| {% for vid in vids %} | |||
| {% assign urlparts = vid.url|split:"/" %} | |||
| {% assign vidno = urlparts[1] %} | |||
| <h3><a href="{{vid.url}}">0x{{urlparts[1]}}</a></h3> | |||
| <h3><a href="{{vid.url}}">0x{{vidno}}</a></h3> | |||
There was a problem hiding this comment.
This line is still generating a pair of p /p around it, which the validator doesn't like. Any thoughts on how to get rid of it @Arachnid ? I wondered if switching the whole line to markdown might work?
There was a problem hiding this comment.
Hm. I suspect it's the empty lines from the assign statements, which markdown is treating as empty paragraphs. Maybe put it inside a div or try moving them all onto one line?
There was a problem hiding this comment.
I manage to fix it by just removing the leading spaces.
|
No worries. I'll have a ponder about external links. There is some caching stuff regarding them and I think you can ignore URLs, so you could ignore the broken ones; it's not perfect, but may be an acceptable compromise. Alternatively you can manually refer to the allowed failures section of Travis. |
|
Can you click the button here to turn on Travis please @Arachnid https://travis-ci.org/pidcodes/pidcodes.github.com/ ? |
|
Of course. Sorry, I thought that was only useful after submitting this PR. |
|
I hoped it would, and indeed after a new commit it's started showing the PR builds: https://travis-ci.org/pidcodes/pidcodes.github.com/builds/164354824 ! |
|
Given this is now green, I'd be tempted to merge it now if you're happy, and I can look at addressing the other bits going forward, but in the meantime you'll already get the benefits of some initial Travis testing being in place. |
|
Indeed I am - thanks again for all the hard work! |
And fix the resulting errors!
You'll need to turn on Travis on your repo to get the benefits, I also highly recommend the protected branch settings on GitHub, even for admins! (You can always temporarily override them as admin if you need to).
Some things to note:
if they were swapped for a valid tag like div or spanif htmlproofer supported HTML5, we could enable that check too.What do you want to do about external links? There are a handful of dead ones currently, hence the allowed failures section on Travis.