Skip to content

pid request for cupkee #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 22, 2017
Merged

pid request for cupkee #223

merged 6 commits into from
Mar 22, 2017

Conversation

dinglixing
Copy link
Contributor

No description provided.

@Arachnid
Copy link
Contributor

Thanks for the Pull request!

Please follow the guide at http://pid.codes/howto; specifically, you need to create an org file that matches the description there. If your project requires custom hardware, the designs must also be checked into your source repository under an open-source license.

@dinglixing
Copy link
Contributor Author

I'll fix it, thanks

@dinglixing
Copy link
Contributor Author

I moved my index.md to org/cupkee.

@peternewman
Copy link
Contributor

Hi @cupkee

As per the notes on http://pid.codes/howto/ you need to split your file up, you need a file in 1209/2016/index.md with the layout: pid stuff and another file in org/cupkee/index.md with the layout: org stuff.

@dinglixing
Copy link
Contributor Author

I really should read the instruction manual carefully

site: http://www.cupkee.cn/
source: https://github.com/cupkee/cupkee/
---
Cupkee is a operating system, it provides a node-like envrionment on mirco-controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, SPaG, micro-controller

site: http://www.cupkee.cn/
source: https://github.com/cupkee/cupkee/
---
Cupkee is a operating system, it provides a node-like envrionment on mirco-controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, SPaG, environment

site: http://www.cupkee.cn/
source: https://github.com/cupkee/cupkee/
---
Cupkee is a operating system, it provides a node-like envrionment on mirco-controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, SPaG, "is an operating system"

site: http://www.cupkee.cn
source: https://github.com/cupkee/cupkee
layout: org
title: Lixing Ding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably wants to be Cupkee too. Otherwise you probably want to put it in a lixingding org folder instead.

@dinglixing
Copy link
Contributor Author

hi @peternewman

Thank you for your meticulous proofreading.
I adjusted immediately.

Copy link
Contributor

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown LGTM

@Arachnid Arachnid merged commit faabc20 into pidcodes:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants