Skip to content

Request PID 2500 for Satprod - Fastkey #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Request PID 2500 for Satprod - Fastkey #456

merged 1 commit into from
Oct 3, 2019

Conversation

satblip
Copy link
Contributor

@satblip satblip commented Aug 30, 2019

  • Adding Satprod Org
  • Adding FastKey, a macro USB keypad

Thanks for the support to open-source!

Arachnid
Arachnid requested changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! PIDs in the 0x1xxx range are reserved - please pick a PID greater than 0x2000.

@satblip
Copy link
Contributor Author

satblip commented Sep 2, 2019

@Arachnid Sorry misread documentation, here it is fixed!

@satblip satblip changed the title Request PID 1987 for Satprod Request PID 2500 for Satprod Sep 3, 2019
@satblip satblip changed the title Request PID 2500 for Satprod Request PID 2500 for Satprod - Fastkey Sep 14, 2019
@Arachnid Arachnid merged commit 3091767 into pidcodes:master Oct 3, 2019
@satblip
Copy link
Contributor Author

satblip commented Oct 4, 2019

@Arachnid thanks!

@satblip satblip deleted the 1987 branch October 4, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arachnid Arachnid Arachnid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satblip @Arachnid