Skip to content

Requesting PID 0D11 and 0D10 for Odiin #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

nitz
Copy link
Contributor

@nitz nitz commented Aug 8, 2020

Requesting the pids 0x0D11 (Odiin Application) and 0x0D10 (Odiin Bootloader) for the Odiin device (https://github.com/nitz/Odiin)

@tannewt tannewt mentioned this pull request Sep 15, 2020
50 tasks
@tannewt
Copy link
Collaborator

tannewt commented Oct 20, 2020

Please pick PIDs that don't start with 0. They are reserved: http://pid.codes/1209/

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch to PIDs that don't start with 0 or 1.

@nitz
Copy link
Contributor Author

nitz commented Oct 21, 2020

Ah, my bad. I assumed because I was using all 'generic' interfaces (CDC, MSC) that the 0x0000-0x0FFF range was okay. I've moved them to 0xD10F and 0xD110.

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tannewt tannewt merged commit 1102b69 into pidcodes:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants