Skip to content

Adding me and my Board #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 26, 2020
Merged

Adding me and my Board #564

merged 8 commits into from
Oct 26, 2020

Conversation

Targett363
Copy link
Contributor

Trying to get the new Beta version of Circuit Python to run on modules on my board, I needed PIDs hope I've done this right I'm on my first day actually using GIT!

@Targett363
Copy link
Contributor Author

Will pull again with correct licence listed!

This was referenced Oct 14, 2020
Closed
Merged
tannewt
tannewt requested changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post the native hardware design files along with a LICENSE file for them in the repos. We don't consider schematic images open because they cannot be modified to produce different hardware.

@Targett363
Copy link
Contributor Author

I think I got it now. The jpeg was just a placeholder, I hadn't pushed the KiCad files! Thanks for all your help.

@Targett363 Targett363 requested a review from tannewt October 18, 2020 16:20
@Targett363
Copy link
Contributor Author

I think I've managed to do it right this time.
Thanks for your time!

tannewt
tannewt requested changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch to PIDs that don't start with 0 or 1. Repo looks good! I'd suggest renaming the license file to LICENSE because it's a standard filename.

@Targett363 Targett363 requested a review from tannewt October 20, 2020 09:50
tannewt
tannewt approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit 4ecfa30 into pidcodes:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Targett363 @tannewt