Request 1209/3320 for MJS2020 sensor board #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Oct 20, 2020
There was a problem hiding this comment.
Please pick a PID that doesn't start with 0. They are reserved: http://pid.codes/1209/
9585477 to
3cd213e
Compare
|
W00ps. I checked carefully and then decided to change the PID just before submitting the PR, should have rechecked carefully. I've rebased on top of master and changed the PID to a non-reserved value. |
|
I was also planning to submit a PID checker script with github integration, but just noticed that it was already added in the recent merging spree, great! I have a small clarification for the docs, though, which I'll submit in a separate PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This board is still in development, but the latest prototype version is already published with full sources, the final board will be published in the same place. The same USB id will be used for the prototype and final versions.