Skip to content

Ask for review pull request for stm32dds #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Conversation

stm32dds
Copy link
Contributor

@stm32dds stm32dds commented Feb 7, 2021

Please review my ask for PID_DD83 on VID_1209

Ask for PID&VID
Ask for PID&VID
@chrysn
Copy link
Contributor

chrysn commented Feb 15, 2021

The software seems to be a mix of MIT-licensed and proprietary licensed data (eg. Middlewares/ST/STM32_USB_Device_Library/Class/CDC/Src/usbd_cdc.c); could you clarify that?

@stm32dds
Copy link
Contributor Author

stm32dds commented Feb 15, 2021 via email

@mlyle
Copy link
Contributor

mlyle commented Feb 15, 2021

The software seems to be a mix of MIT-licensed and proprietary licensed data (eg. Middlewares/ST/STM32_USB_Device_Library/Class/CDC/Src/usbd_cdc.c); could you clarify that?

The vast majority of STM32 stuff that uses USB is contaminated by these files.

First, the stuff subject Ultimate Liberty is open source, even if it is not compatible with many other open source licenses.

Second, literally dozens of projects have been approved by pidcodes by things that use ST's USB device library. Is this a problem now?

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Please update the links if you create your own hardware to go with it.

@tannewt tannewt merged commit 1a3b9ba into pidcodes:master Feb 16, 2021
@stm32dds
Copy link
Contributor Author

stm32dds commented Feb 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants