VictorGrig USBscope PID pull request #3 #78
Conversation
All files of the project have been uploaded
VictorGrig USBscope PID pull request (updated)
|
Looks good, thanks. Your repository has two LICENSE files, one CC0 and the other MIT. Were you intending to dual-license under both? |
|
Ah, sorry for my inattention. CC0 license has been copied by mistake, The MIT License file is primary now. |
| --- | ||
| layout: pid | ||
| title: USBscope | ||
| owner: Victor Grigoryev |
There was a problem hiding this comment.
The 'owner' field needs to match the directory name of the directory in which your org file is ('USBscope').
There was a problem hiding this comment.
Finally index.md should be like this, isn`t it?
---
layout: pid
title: USBscope
owner: USBscope
license: MIT
site: http://yveslebrac.blogspot.com/2008/10/cheapest-dual-trace-scope-in-galaxy.html
source: https://github.com/VictorGrig/USBscope
---|
As it stands, the device will be identified in the PID list as "USBScope USBScope". If you're happy with that, I'm happy to merge this, but if you'd prefer something more descriptive, you should change the title of the org to something more descriptive, such as your name. It would probably make sense to change the directory it's in if you do that too. |
|
Okay, I got confused little bit =) Let's set my identifier as |
|
Set the "title" field in the org file to "Victor Grigoryev". For the sake of clarity and any future pids, rename the directory it's in to something like "victor-grigoryev", and update the "owner" field in the PID file to match. |
Project properties have been updated
|
Got it.
|
…equest VictorGrig USBscope PID pull request #3
General clean-up. My project has been moved into its own new repository as you adviced at #77, it contains: