nits: a couple small tweaks while merging upstream #117
Conversation
* small tweak to wording for greedy args (thought it read clearer). * received warning from linter for capital Object in JSDoc.
| @@ -555,8 +555,7 @@ test('strict: when short option and suspect value then throws with whole expecte | |||
|
|
|||
| assert.throws(() => { | |||
| parseArgs({ args, options }); | |||
| // eslint-disable-next-line max-len | |||
| }, /Error: Option '-w' argument is ambiguous\.\nDid you forget to specify the option argument for '-w'\?\nOr to specify an option argument starting with a dash use '--with=-XYZ' or '-w-XYZ'\./ | |||
| }, /To specify an option argument starting with a dash use '--with=-XYZ' or '-w-XYZ'\./ | |||
There was a problem hiding this comment.
Minor, and can safely be ignored. I deliberately had a couple of tests of the "whole" error message. But just take whole out of the test name and I'll be happy. 😄
There was a problem hiding this comment.
The error message string varies a bit in Node.js (because of the class name differing).
If you don't mind my preference is the slightly shorter comparison.
|
An aside: with a lot of recent suggestions on the node PR, would you like to make those changes upstream and later copy-down to |
I'll just make a new PR with the upstream changes. |
A couple small tweaks made while synchronizing with Node.js repository.