Skip to content

Conversation

bcoe
Copy link
Collaborator

@bcoe bcoe commented Apr 10, 2022

Switch to using an error that already exists, to simplify merging into Node.js.

@bcoe bcoe merged commit 084a23f into main Apr 10, 2022
@bcoe bcoe deleted the switch-error-name branch April 10, 2022 16:53
@shadowspawn
Copy link
Collaborator

There is a potential difference between errors made by the author, and errors made by the end user that the author wants to catch.

I think it is a good idea to use the preexisting error for this case which is an author error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants