link GitHub breadcrumb to specific files #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file in our docs repo
…new docs are added
Kully
reviewed
Aug 17, 2018
| @@ -0,0 +1,81 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm curious, how is this script called? Are you reading the notebook file directly or have converted the script to a python file?
There was a problem hiding this comment.
I wrote it in a notebook and, yeah, you run it from there at the moment. It only needs to be run after new python docs are added to repo (even if it was done once a month that would be better than nothing) but it would make sense to update publisher to append a new entry to git_url.yml automatically.
| </div> | ||
| {% endif %} |
There was a problem hiding this comment.
all looks good! Tried it and the links work well
|
💃 |
Kully
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull fixes issue 805 by linking the Fork on Github breadcrumb of R docs directly to the .Rmd file and and the docs of all other languages will link to the directory containing the file relevant.