Skip to content

Minor updates to plot.ly/api #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 4, 2018
Merged

Minor updates to plot.ly/api #1057

merged 9 commits into from
Sep 4, 2018

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Aug 27, 2018

closes https://github.com/plotly/streambed/issues/11343

changed API Libraries to Open Source Graphing Libraries throughout.

added a box for dash and for REST API.

Removed API Protocol and Excel menus.

Changed Plotly Workshop to DASH DAQ.

changed footers to match plot.ly : closes #1055

@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 27, 2018

Outstanding question: which images should I use for the REST API box?

@jackparmer
Copy link
Contributor

This one looks pretty good in terms of matching the others and being clean:

https://cdn-images-1.medium.com/max/1200/1*uHzooF1EtgcKn9_XiSST4w.png

@Kully
Copy link
Contributor

Kully commented Aug 29, 2018

Going to give this a review now

@Kully
Copy link
Contributor

Kully commented Aug 29, 2018

The REST icon is too small. Can you make it bigger so that it matches the size of the other icons around it?

screen shot 2018-08-29 at 12 28 50 pm

Also replace the dash icon you are using with
https://github.com/plotly/design-assets/blob/master/logos/dash/images/dash-logo-avatar.png.

screen shot 2018-08-29 at 12 44 29 pm

It is the standard avatar for dash and consistent with the icon used in the page it links to.

@Kully
Copy link
Contributor

Kully commented Aug 29, 2018

Not blocking 🚫 , but I think putting Python, R and Others sections on one line would look better in my opinion. All that extra white space on the Others section just looks weird to me.

screen shot 2018-08-29 at 12 51 16 pm

@@ -19,7 +19,7 @@
<div class="--title">
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div>
<div class="--body">
<h1>Plotly Python Library 3D Charts</h1>
<h1>Plotly Python Open Source Library 3D Charts</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be Open Source Graphing Library to be consistent?

@@ -19,7 +19,7 @@
<div class="--title">
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div>
<div class="--body">
<h1>Plotly Python Library Basic Charts</h1>
<h1>Plotly Python Open Source Library Basic Charts</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here as ^

@@ -19,7 +19,7 @@
<div class="--title">
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div>
<div class="--body">
<h1>Plotly Python Library Fundamentals</h1>
<h1>Plotly Python Open Source Library Fundamentals</h1>
Copy link
Contributor

@Kully Kully Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: ...Graphing Library

@@ -31,7 +31,7 @@ <h4 id="New-to-Plotly?">New to Plotly?<a class="anchor-link" href="#New-to-Plotl
</div>
<div class="inner_cell">
<div class="text_cell_render border-box-sizing rendered_html">
<h4 id="Online-Configuration-Options">Online Configuration Options<a class="anchor-link" href="#Online-Configuration-Options">&#194;&#182;</a></h4><p>Config options set via our API libraries are overridden on graphs hosted on plot.ly (i.e. when working online).
<h4 id="Online-Configuration-Options">Online Configuration Options<a class="anchor-link" href="#Online-Configuration-Options">&#194;&#182;</a></h4><p>Config options set via our Open Source Graphing libraries are overridden on graphs hosted on plot.ly (i.e. when working online).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize libraries -> Libraries for consistency

@@ -19,7 +19,7 @@
<div class="--title">
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div>
<div class="--body">
<h1>Plotly Python Library Scientific Charts</h1>
<h1>Plotly Python Open Source Library Scientific Charts</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphing library

@@ -12381,7 +12381,7 @@ <h4 class="delta heading text--left">The Plotly community</h4>
</div><!--
--><div class="grid__item one-half">
<h4 class="delta heading text--left">Programmer? We've got you covered.</h4>
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">API libraries</a><br>
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">Open Source Graphing libraries</a><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital L on libraries

@@ -19,7 +19,7 @@
<div class="--title">
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div>
<div class="--body">
<h1>Plotly Python Library Statistical Charts</h1>
<h1> Library Statistical Charts</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing Plotly Python here?

@@ -12381,7 +12381,7 @@ <h4 class="delta heading text--left">The Plotly community</h4>
</div><!--
--><div class="grid__item one-half">
<h4 class="delta heading text--left">Programmer? We've got you covered.</h4>
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">API libraries</a><br>
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">Open Source Graphing libraries</a><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital L

@@ -12381,7 +12381,7 @@ <h4 class="delta heading text--left">The Plotly community</h4>
</div><!--
--><div class="grid__item one-half">
<h4 class="delta heading text--left">Programmer? We've got you covered.</h4>
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">API libraries</a><br>
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">Open Source Graphing libraries</a><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital L

@@ -12,7 +12,7 @@
<div class="--title">
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/pandas-small.png" alt=""></div>
<div class="--body">
<h1>Plotly Python Library for Pandas</h1>
<h1>Plotly Python Open Source Library for Pandas</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphing?

@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 29, 2018

I standardized the use of "Open Source Graphing Libraries" throughout the site.

In terms of images, does anyone know how i can host images on images.plot.ly? That's where the other images for the homepage are being served from.

@Kully
Copy link
Contributor

Kully commented Aug 30, 2018

@jdamiba give me a ping when you've addressed/responded to all my comments. Thanks 😄

@nicolaskruchten
Copy link
Contributor

Once you deploy https://github.com/plotly/plotly.github.io/pull/366 you can use that image ;)

@cldougl cldougl requested review from cldougl and removed request for jackparmer and priyatharsan September 4, 2018 15:23
@cldougl cldougl added the ReviewReady This PR is ready for review label Sep 4, 2018
Resolving conflicts with source-design-merge
@cldougl
Copy link
Member

cldougl commented Sep 4, 2018

I'm a bit unsure about adding the rest library in that spot as it is not open-sourced
screen shot 2018-09-04 at 11 58 51 am

@jdamiba
Copy link
Contributor Author

jdamiba commented Sep 4, 2018

I removed the REST API box. I like the way it looks now a lot since Dash gets a level all to itself.

screen shot 2018-09-04 at 1 18 31 pm

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@cldougl
Copy link
Member

cldougl commented Sep 4, 2018

We may want to consider making the icons per row 3, 2 rather than 4, 1 in the above screenshot though that can be done in a follow up pr

@nicolaskruchten
Copy link
Contributor

+1 to the 3/2 vs 4/1 per row.

Other thoughts:

  • We want to move away from "Download free and open-source clients for:"
  • We need to be clear that Dash isn't like the others... it's not another "Open Source Graphing" library per se... App Development Library?

@nicolaskruchten
Copy link
Contributor

OK, let's ship it 💃

@jdamiba jdamiba merged commit 0757771 into source-design-merge Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReviewReady This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align footer with plot.ly
5 participants