-
-
Notifications
You must be signed in to change notification settings - Fork 544
Minor updates to plot.ly/api #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Outstanding question: which images should I use for the REST API box? |
This one looks pretty good in terms of matching the others and being clean: https://cdn-images-1.medium.com/max/1200/1*uHzooF1EtgcKn9_XiSST4w.png |
Going to give this a review now |
The REST icon is too small. Can you make it bigger so that it matches the size of the other icons around it? Also replace the dash icon you are using with It is the standard avatar for dash and consistent with the icon used in the page it links to. |
@@ -19,7 +19,7 @@ | |||
<div class="--title"> | |||
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div> | |||
<div class="--body"> | |||
<h1>Plotly Python Library 3D Charts</h1> | |||
<h1>Plotly Python Open Source Library 3D Charts</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be Open Source Graphing Library
to be consistent?
@@ -19,7 +19,7 @@ | |||
<div class="--title"> | |||
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div> | |||
<div class="--body"> | |||
<h1>Plotly Python Library Basic Charts</h1> | |||
<h1>Plotly Python Open Source Library Basic Charts</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here as ^
@@ -19,7 +19,7 @@ | |||
<div class="--title"> | |||
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div> | |||
<div class="--body"> | |||
<h1>Plotly Python Library Fundamentals</h1> | |||
<h1>Plotly Python Open Source Library Fundamentals</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here: ...Graphing Library
@@ -31,7 +31,7 @@ <h4 id="New-to-Plotly?">New to Plotly?<a class="anchor-link" href="#New-to-Plotl | |||
</div> | |||
<div class="inner_cell"> | |||
<div class="text_cell_render border-box-sizing rendered_html"> | |||
<h4 id="Online-Configuration-Options">Online Configuration Options<a class="anchor-link" href="#Online-Configuration-Options">¶</a></h4><p>Config options set via our API libraries are overridden on graphs hosted on plot.ly (i.e. when working online). | |||
<h4 id="Online-Configuration-Options">Online Configuration Options<a class="anchor-link" href="#Online-Configuration-Options">¶</a></h4><p>Config options set via our Open Source Graphing libraries are overridden on graphs hosted on plot.ly (i.e. when working online). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capitalize libraries
-> Libraries
for consistency
@@ -19,7 +19,7 @@ | |||
<div class="--title"> | |||
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div> | |||
<div class="--body"> | |||
<h1>Plotly Python Library Scientific Charts</h1> | |||
<h1>Plotly Python Open Source Library Scientific Charts</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graphing library
all_static/images/Plotly-Feed.html
Outdated
@@ -12381,7 +12381,7 @@ <h4 class="delta heading text--left">The Plotly community</h4> | |||
</div><!-- | |||
--><div class="grid__item one-half"> | |||
<h4 class="delta heading text--left">Programmer? We've got you covered.</h4> | |||
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">API libraries</a><br> | |||
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">Open Source Graphing libraries</a><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital L on libraries
@@ -19,7 +19,7 @@ | |||
<div class="--title"> | |||
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/python-small.png" alt=""></div> | |||
<div class="--body"> | |||
<h1>Plotly Python Library Statistical Charts</h1> | |||
<h1> Library Statistical Charts</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you removing Plotly Python
here?
all_static/images/Plotly-feed2.html
Outdated
@@ -12381,7 +12381,7 @@ <h4 class="delta heading text--left">The Plotly community</h4> | |||
</div><!-- | |||
--><div class="grid__item one-half"> | |||
<h4 class="delta heading text--left">Programmer? We've got you covered.</h4> | |||
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">API libraries</a><br> | |||
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">Open Source Graphing libraries</a><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital L
all_static/images/Plotly.html
Outdated
@@ -12381,7 +12381,7 @@ <h4 class="delta heading text--left">The Plotly community</h4> | |||
</div><!-- | |||
--><div class="grid__item one-half"> | |||
<h4 class="delta heading text--left">Programmer? We've got you covered.</h4> | |||
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">API libraries</a><br> | |||
See our <a href="https://plot.ly/api/" target="_self" class="link link--impt epsilon">Open Source Graphing libraries</a><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital L
@@ -12,7 +12,7 @@ | |||
<div class="--title"> | |||
<div class="--category-img"><img src="https://plot.ly/gh-pages/documentation/static/images/pandas-small.png" alt=""></div> | |||
<div class="--body"> | |||
<h1>Plotly Python Library for Pandas</h1> | |||
<h1>Plotly Python Open Source Library for Pandas</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graphing?
I standardized the use of "Open Source Graphing Libraries" throughout the site. In terms of images, does anyone know how i can host images on images.plot.ly? That's where the other images for the homepage are being served from. |
@jdamiba give me a ping when you've addressed/responded to all my comments. Thanks 😄 |
Once you deploy https://github.com/plotly/plotly.github.io/pull/366 you can use that image ;) |
Resolving conflicts with source-design-merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
We may want to consider making the icons per row 3, 2 rather than 4, 1 in the above screenshot though that can be done in a follow up pr |
+1 to the 3/2 vs 4/1 per row. Other thoughts:
|
OK, let's ship it 💃 |
closes https://github.com/plotly/streambed/issues/11343
changed API Libraries to Open Source Graphing Libraries throughout.
added a box for dash and for REST API.
Removed API Protocol and Excel menus.
Changed Plotly Workshop to DASH DAQ.
changed footers to match plot.ly : closes #1055