Skip to content

Tick-formatting doc for plotly.js #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 5, 2019
Merged

Tick-formatting doc for plotly.js #1211

merged 9 commits into from
Feb 5, 2019

Conversation

priyatharsan
Copy link
Contributor

related to : #1137

@priyatharsan priyatharsan requested a review from cldougl December 17, 2018 23:03
@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Dec 17, 2018
@priyatharsan
Copy link
Contributor Author

priyatharsan commented Dec 17, 2018 •
edited
Loading

@cldougl let me know if these examples are good enough so that I can make the same in Python/R.
I wanted the examples as simple as possible, but I could improvise them if needed.

michaelbabyn
michaelbabyn requested changes Dec 19, 2018
View reviewed changes
@priyatharsan
Copy link
Contributor Author

@michaelbabyn I simplified the example for tickformatstops now.

@cldougl cldougl removed their request for review January 30, 2019 15:06
@cldougl
Copy link
Member

cldougl commented Jan 30, 2019

@michaelbabyn can you take another quick look at this update?

michaelbabyn
michaelbabyn requested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 after formatting/code style changes.

@priyatharsan priyatharsan removed the ReviewReady This PR is ready for review label Feb 5, 2019
@priyatharsan priyatharsan merged commit 85f50aa into source-design-merge Feb 5, 2019
@priyatharsan priyatharsan deleted the tickformatting-doc branch February 5, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbabyn michaelbabyn michaelbabyn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyatharsan @cldougl @michaelbabyn