Skip to content

Add sunburst documentation #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2019
Merged

Add sunburst documentation #1300

merged 5 commits into from
Apr 25, 2019

Conversation

michaelbabyn
Copy link
Contributor

@michaelbabyn michaelbabyn commented Apr 12, 2019

resolves #1294

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Apr 12, 2019
@michaelbabyn michaelbabyn changed the title Add JS sunburst documentation Add sunburst documentation Apr 16, 2019
---
title: Javascript Graphing Library D3.js-based Sunburst Plots | Examples | Plotly
name: Sunburst Plots
permalink: javascript/sunburst/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make the permalink javascript/sunburst-charts/

@@ -0,0 +1,16 @@
---
title: Javascript Graphing Library D3.js-based Sunburst Plots | Examples | Plotly
name: Sunburst Plots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a suggestion but I think the terms Sunburst Charts or Sunburst Graphs are a bit more common

---
title: R Sunburst Charts | Examples | Plotly
name: Sunburst Charts
permalink: r/sunburst/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sunburst-charts

@@ -0,0 +1,292 @@
---
permalink: python/sunburst/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sunburst-charts

@cldougl cldougl removed the ReviewReady This PR is ready for review label Apr 24, 2019
@@ -627,6 +627,14 @@ <h4 class="example-section-title" id="layout-options">
</div>
{% endif %}

{% if page.dash_url %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this codeblock added on purpose to this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just a dirty repo... I'm getting rid of it.

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 thanks for making the updates!!!

@michaelbabyn michaelbabyn merged commit 17dc302 into source-design-merge Apr 25, 2019
@michaelbabyn michaelbabyn deleted the sunburst-docs branch April 25, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sunburst docs
2 participants