Skip to content

roughing in python-next #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 8, 2019
Merged

roughing in python-next #1387

merged 17 commits into from
Jul 8, 2019

Conversation

nicolaskruchten
Copy link
Contributor

No description provided.

@nicolaskruchten
Copy link
Contributor Author

@michaelbabyn this is what I've got so far... looking ok, and the changes don't seem super-intrusive :)

image

{% assign languagelistimg = site.posts | where:"language","python" |where:"display_as","chart_events" | where:"has_thumbnail",true | where: "layout","user-guide" | sort: "order" %}
{% include documentation_eg.html %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to update the documentation_eg.html file so that the updates to the figurewidget section from the python reorg get applied here too. This will make the figureWidgets section display thumbnails like the others

Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good enough to get merged. 💃

@nicolaskruchten nicolaskruchten marked this pull request as ready for review July 8, 2019 18:15
@nicolaskruchten nicolaskruchten merged commit 77a6eb8 into source-design-merge Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants