Skip to content

Add docs and a codepen explaining null vs. undefined in restyle #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2017
Merged

Add docs and a codepen explaining null vs. undefined in restyle #700

merged 1 commit into from
Feb 23, 2017

Conversation

rreusser
Copy link
Contributor

@rreusser rreusser commented Feb 23, 2017 •
edited
Loading

This PR adds docs and a codepen explaining the behavior of null vs. undefined. (null affirmatively resets to default, undefined is understood as unspecified and is ignored.) It's a subtle-but-useful feature that was added in plotly/plotly.js#844

@cldougl
Copy link
Member

cldougl commented Feb 23, 2017

nice @rreusser !!
I think it may be helpful to add a null/null ("reset") button in so that users can see how each option affects the graph from the beginning state.

@rreusser
Copy link
Contributor Author

Good idea. Updated!

@cldougl
Copy link
Member

cldougl commented Feb 23, 2017

💃 💃

@rreusser rreusser merged commit 7463e10 into source-design-merge Feb 23, 2017
@rreusser rreusser deleted the plotlyjs-null-vs-undefined branch February 23, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement plotly.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rreusser @cldougl