This repository was archived by the owner on Jun 4, 2024. It is now read-only.
wrap JSON.parse calls in try-catch blocks #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failling, but I think it's because of throttling. I'll upgrade the test-account. |
|
@alexander-daniel looks good to me. 💃 once you figure out the test failures. |
|
@etpinard @bpostlethwaite I upgraded the |
alexander-daniel
added a commit
that referenced
this pull request
Dec 30, 2015
wrap JSON.parse calls in try-catch blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #37
@etpinard @bpostlethwaite
We weren't wrapping
JSON.parsecalls in try-catch blocks, so if the server sent anything other than JSON back, we'd have uncaught breakages!