Skip to content

Toby cookbook lines #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 7, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e47ca93
expect_shape for hline
tdhock Mar 31, 2015
3ef9be5
test scatter facet lines
tdhock Mar 31, 2015
b60d935
only copy global mapping to layer if inherit.aes
tdhock Mar 31, 2015
1bea709
compute ranges for factors
tdhock Apr 1, 2015
8e68d8a
also use ranges for date and datetime variables
tdhock Apr 1, 2015
305ad6c
tests fail
tdhock Apr 1, 2015
7308760
simplify factor handling
tdhock Apr 1, 2015
6c72262
handle dodged factors with aes.name
tdhock Apr 1, 2015
84ab366
special cases
tdhock Apr 1, 2015
6318787
markLegends + boxplot = markSplit
tdhock Apr 1, 2015
4a2dc57
no need for workaround
tdhock Apr 1, 2015
a4d0059
testing showlegend=FALSE for each trace is sufficient
tdhock Apr 1, 2015
4a7f713
set showlegend=FALSE for all but the first trace with a given name
tdhock Apr 2, 2015
56ede93
merge conflict
tdhock Apr 2, 2015
3105143
use more complicated legend merging from master
tdhock Apr 2, 2015
bd8c3f6
test for no legends
tdhock Apr 8, 2015
5fa2434
hide boxplot legends
tdhock Apr 14, 2015
96f0d40
clean up comments
tdhock Apr 14, 2015
f0eb05e
version update
tdhock Apr 15, 2015
8f937e0
Use ||, not |, for logical vector of length 1
cpsievert May 2, 2015
9ab52e1
Resolve merge conflicts with master
cpsievert May 2, 2015
f90928b
merge conflicts with master
cpsievert May 5, 2015
d142570
test fixes for cookbook-lines (due to changes in gg2list())
cpsievert May 5, 2015
ab4ca1c
Fix style (notably, RStudio indentation)
mkcor May 5, 2015
498455d
Update version and docs
mkcor May 5, 2015
4cfedf9
Fix merge conflicts with master
mkcor May 5, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge conflicts with master
  • Loading branch information
cpsievert committed May 5, 2015
commit f90928b9a0ed59d4af6fd41d0f79aab75ff4fa3d
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: plotly
Type: Package
Title: Interactive, publication-quality graphs online.
Version: 0.5.30
Version: 0.5.31
Authors@R: c(person("Chris", "Parmer", role = c("aut", "cre"),
email = "chris@plot.ly"),
person("Scott", "Chamberlain", role = "aut",
Expand Down
6 changes: 5 additions & 1 deletion NEWS
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
0.5.30 -- 5 May 2015
0.5.31 -- 5 May 2015

Add test-cookbook-lines.R and fix bugs that showed up in those tests.

0.5.30 -- 4 May 2015

Let gg2list() return a figure object.

0.5.29 -- 16 April 2015

geom_density() as filled area chart #202
Expand Down
6 changes: 3 additions & 3 deletions tests/testthat/test-cookbook-axes.R
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,14 @@ bp.scale.hide <- bp + scale_y_continuous(limits=c(5, 7.5))
test_that("scale_y(limits) hides points", {
info <- expect_traces(bp.scale.hide, 3, "scale.hide")
expect_legend(info, leg())
expect_equal(info$kwargs$layout$yaxis$range, c(5, 7.5))
expect_equal(info$layout$yaxis$range, c(5, 7.5))
})

bp.coord <- bp + coord_cartesian(ylim=c(5, 7.5))
test_that("Using coord_cartesian zooms into the area", {
info <- expect_traces(bp.coord, 3, "coord-ylim")
expect_legend(info, leg())
expect_equal(info$kwargs$layout$yaxis$range, c(5, 7.5))
expect_equal(info$layout$yaxis$range, c(5, 7.5))
})

# Create some noisy exponentially-distributed data
Expand Down Expand Up @@ -189,7 +189,7 @@ bp.fonts <- bp +
test_that("element_text face, colour, size, angle, vjust, size", {
info <- expect_traces(bp.fonts, 3, "fonts")
expect_legend(info, leg())
x <- info$kwargs$layout$xaxis
x <- info$layout$xaxis
xtitle <- x[["titlefont"]]
xtick <- x[["tickfont"]]
expect_identical(xtitle$color, toRGB("#990000"))
Expand Down
3 changes: 2 additions & 1 deletion tests/testthat/test-ggplot-bar.R
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ test_that("Very basic bar graph", {
expect_null(tr$marker$line$width)
expect_false(tr$showlegend)
}
expect_null(info$kwargs$layout$annotations)
expect_null(info$layout$annotations)
expect_false(info$layout$showlegend)
})

test_that("Map the time of day to different fill colors", {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.